Update torchaudio resampling #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Huh, I did a review very soon after you created this PR. Where has it gone?! Will have to do it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6
Summary of Changes
0.9.0), which contains various resampling improvementsresample_waveformwith the newfunctional.resample, sincecompliance.kaldi.resampleis being deprecatedfunctional.resamplefrom impulse graphs and replacedfunctional.resamplespectrograms withtransforms.Resampleusing a largerlowpass_filter_widthparameter, similar thejuliusplots.functional.resampleshould numerically matchtransforms.Resample, so plotting both seems redundantLet me know if you have any questions or suggestions!